Barium and Zinc doped CdS thin films were deposited by simple and easy spray pyrolysis method at 400°C. The crystallographic structure and the crystallite size were studied by the X-ray diffraction (XRD) pattern. Optical band gap were studied by optical absorption spectroscopy and electrical measurements by means of electrical resistivity studied by using two probe methods. On doping of Zinc and Barium, the crystallite sizes were found to increase. The optical energy band gap observed to be from 2.48 to 2.41 eV for as deposited and Zinc, Barium doped CdS thin film. The film exhibits photoconductivity phenomena suggesting its useful for sensors and photovoltaic device and from the electrical conductivity was found to be of n-type conductivity.